terraform v0.12.0 not supported

[lucklove]

Bug Report

What version of Kubernetes are you using?

What version of TiDB Operator are you using?

What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods?

What's the status of the TiDB cluster pods?

What did you do?

Run terraform apply as documented. What did you expect to see? Something like

Apply complete! Resources: 67 added, 0 changed, 0 destroyed.

Outputs:

bastion_ip = [
    52.14.50.145
]
eks_endpoint = https://E10A1D0368FFD6E1E32E11573E5CE619.sk1.us-east-2.eks.amazonaws.com
eks_version = 1.12
monitor_endpoint = http://abd299cc47af411e98aae02938da0762-1989524000.us-east-2.elb.amazonaws.com:3000
region = us-east-2
tidb_dns = abd2e3f7c7af411e98aae02938da0762-17499b76b312be02.elb.us-east-2.amazonaws.com
tidb_port = 4000
tidb_version = v3.0.0-rc.1

What did you see instead?

Error: Unsupported block type

  on data.tf line 16, in data "template_file" "tidb_cluster_values":
  16:   vars  {

Blocks of type "vars" are not expected here. Did you mean to define argument
"vars"? If so, use the equals sign to assign it a value.

Error: Unsupported block type

  on .terraform/modules/eks/aws_auth.tf line 41, in data "template_file" "launch_template_worker_role_arns":
  41:   vars {

Blocks of type "vars" are not expected here. Did you mean to define argument
"vars"? If so, use the equals sign to assign it a value.

Error: Unsupported block type

  on .terraform/modules/eks/aws_auth.tf line 50, in data "template_file" "worker_role_arns":
  50:   vars {

Blocks of type "vars" are not expected here. Did you mean to define argument
"vars"? If so, use the equals sign to assign it a value.
...

[lucklove]

$ terraform version
Terraform v0.12.0
+ provider.aws v2.13.0
+ provider.external v1.1.2
+ provider.helm v0.9.1
+ provider.local v1.2.2
+ provider.null v2.1.2
+ provider.template v2.1.2
+ provider.tls v2.0.1

[weekface]

@tennix PTAL

[jlerche]

I don't think any of the scripts do anything fancy, we should be able to do terraform 0.12upgrade and get it running without too much effort. I will be upgrading the GCP one at the same time as fixing #522

[gregwebs]

GCP is upgraded now. #616 upgrades AWS, please re-open this issue if you have any more problems.