pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.2k stars 490 forks source link

ebs br: add check wal warmup option #5587

Closed YuJuncen closed 3 months ago

YuJuncen commented 3 months ago

What problem does this PR solve?

What is changed and how does it work?

This PR provide restore capability to check wal corruption only during restore by specifying the warmup strategy of volumerestore to check-wal-only

cc #5582

Code changes

Tests

Side effects

Related changes

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 25.00000% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 61.48%. Comparing base (5f4207d) to head (d03b6d9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5587 +/- ## ========================================== - Coverage 61.53% 61.48% -0.06% ========================================== Files 235 235 Lines 30314 30343 +29 ========================================== + Hits 18654 18656 +2 - Misses 9794 9816 +22 - Partials 1866 1871 +5 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5587/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.48% <25.00%> (-0.06%)` | :arrow_down: |
BornChanger commented 3 months ago

/run-pull-e2e-kind-br

ti-chi-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb-operator/blob/master/OWNERS)~~ [BornChanger,WangLe1321] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BornChanger commented 3 months ago

/cherry-pick release-1.5

ti-chi-bot commented 3 months ago

@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to [this](https://github.com/pingcap/tidb-operator/pull/5587#issuecomment-2014906435): >/cherry-pick release-1.5 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 3 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 3 months ago

New changes are detected. LGTM label has been removed.

ti-chi-bot commented 3 months ago

@BornChanger: new pull request created to branch release-1.5: #5589.

In response to [this](https://github.com/pingcap/tidb-operator/pull/5587#issuecomment-2014906435): >/cherry-pick release-1.5 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.