Closed fgksgf closed 6 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: csuzhangxc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/run-all-tests
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.66%. Comparing base (
6de3eb2
) to head (066f8bc
).
/run-pull-e2e-kind-br
/run-pull-e2e-kind-across-kubernetes
Timeline:
2024-03-22 08:49:18.159205374 +0000 UTC m=+1625785.181451758
: :ballot_box_with_check: agreed by csuzhangxc.2024-03-22 11:49:28.863976132 +0000 UTC m=+1636595.886222521
: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].@fgksgf: Your PR was out of date, I have automatically updated it for you.
New changes are detected. LGTM label has been removed.
/run-all-tests
What problem does this PR solve?
In some case, tidb servers may not be ready to serve traffic even the readiness probe can establish connection on port 4000 or 10080. Therefore, a better way maybe using the mysql protocol to probe.
What is changed and how does it work?
This PR adds a
CustomizedStartupProbe
field, we can provide our own binary as the startup probe for TiDB.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.