pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.2k stars 490 forks source link

warmup-image: test WAL files while warming up (#5566) #5593

Closed ti-chi-bot closed 3 months ago

ti-chi-bot commented 3 months ago

This is an automated cherry-pick of #5566

What problem does this PR solve?

This PR added an ad-hoc precheck for the warmup script.

What is changed and how does it work?

We will run ldb dump_wal on each log files found. It is an ad-hoc solution because the version of ldb is hard-coded. Please don't merge them and only use this to build the warmup image.

Code changes

Tests

I run this on a simple storage that contains some corrupted SST files:

CleanShot 2024-03-06 at 17 02 14@2x

Side effects

Related changes

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.86%. Comparing base (f671d78) to head (bb90b21).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.5 #5593 +/- ## =============================================== + Coverage 61.55% 61.86% +0.31% =============================================== Files 229 242 +13 Lines 29329 33295 +3966 =============================================== + Hits 18052 20598 +2546 - Misses 9497 10805 +1308 - Partials 1780 1892 +112 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5593/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.34% <ø> (?)` | | | [unittest](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.54% <ø> (-0.01%)` | :arrow_down: |
BornChanger commented 3 months ago

/run-pull-e2e-kind-br

BornChanger commented 3 months ago

/approve

ti-chi-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb-operator/blob/release-1.5/OWNERS)~~ [BornChanger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BornChanger commented 3 months ago

/run-pull-e2e-kind