pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.2k stars 490 forks source link

add nodeSelector support for TidbInitializer Pod (#5594) #5595

Closed ti-chi-bot closed 3 months ago

ti-chi-bot commented 3 months ago

This is an automated cherry-pick of #5594

What problem does this PR solve?

add nodeSelector support for TidbInitializer Pod

What is changed and how does it work?

Code changes

Tests

apiVersion: pingcap.com/v1alpha1
kind: TidbInitializer
spec:
    nodeSelector:
      kubernetes.io/hostname: kind-control-plane
apiVersion: v1
kind: Pod
spec:
    nodeSelector:
      kubernetes.io/hostname: kind-control-plane

Side effects

Related changes

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

ti-chi-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tidb-operator/blob/release-1.5/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
csuzhangxc commented 3 months ago

/run-all-tests

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.43%. Comparing base (8e98fef) to head (d0890d0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.5 #5595 +/- ## =============================================== + Coverage 61.56% 65.43% +3.87% =============================================== Files 229 242 +13 Lines 29329 33296 +3967 =============================================== + Hits 18055 21786 +3731 - Misses 9495 9643 +148 - Partials 1779 1867 +88 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5595/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `39.35% <0.00%> (?)` | | | [unittest](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.55% <100.00%> (-0.01%)` | :arrow_down: |
csuzhangxc commented 3 months ago

/run-pull-e2e-kind

csuzhangxc commented 3 months ago

/run-pull-e2e-kind

csuzhangxc commented 3 months ago

/run-pull-e2e-kind