Add 10s sleep prior to warmup exit for sidecars to upload logs

michaelmdeng commented 3 months ago

What problem does this PR solve?

Add sleep before exiting the warmup container. This is needed to give time to sidecar containers to upload logs/metrics before warmup completes.

What is changed and how does it work?

Code changes

[ ] Has Go code change
[ ] Has CI related scripts change

Tests

[ ] Unit test
[ ] E2E test
[x] Manual test

Ran EBS snapshot restore w/ updated warmup pod and observe restore functions as expected.

[ ] No code

Side effects

[ ] Breaking backward compatibility
[ ] Other side effects:

Related changes

[ ] Need to cherry-pick to the release branch
[ ] Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

sre-bot commented 3 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: BornChanger
:x: Michael Deng

Michael Deng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.74%. Comparing base (685a06d) to head (3ac9bc3).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #5599 +/- ## ========================================== + Coverage 61.49% 67.74% +6.24% ========================================== Files 235 246 +11 Lines 30337 34230 +3893 ========================================== + Hits 18655 23188 +4533 + Misses 9813 9144 -669 - Partials 1869 1898 +29 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5599/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `48.11% <ø> (?)` | | | [unittest](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.49% <ø> (ø)` | |

BornChanger commented 3 months ago

/cc @WangLe1321

BornChanger commented 3 months ago

/cc @YuJuncen

ti-chi-bot[bot] commented 3 months ago

@YuJuncen: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tidb-operator/pull/5599#pullrequestreview-1973394132): >LGTM Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ti-chi-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb-operator/blob/master/OWNERS)~~ [BornChanger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

BornChanger commented 3 months ago

/retest

ti-chi-bot[bot] commented 3 months ago

[LGTM Timeline notifier]

Timeline:

2024-04-02 10:58:49.876668754 +0000 UTC m=+355191.404209297: :ballot_box_with_check: agreed by BornChanger.
2024-04-02 11:08:14.471500055 +0000 UTC m=+355755.999040596: :heavy_multiplication_x::repeat: reset by BornChanger.

ti-chi-bot[bot] commented 3 months ago

New changes are detected. LGTM label has been removed.

BornChanger commented 3 months ago

/retest

BornChanger commented 3 months ago

/run-pull-e2e-kind-across-kubernetes

BornChanger commented 3 months ago

@michaelmdeng please sign cla with the correct id.

BornChanger commented 3 months ago

/cherry-pick release-1.5

ti-chi-bot commented 3 months ago

@BornChanger: new pull request created to branch release-1.5: #5607.

In response to [this](https://github.com/pingcap/tidb-operator/pull/5599#issuecomment-2036684627): >/cherry-pick release-1.5 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

pingcap / tidb-operator