pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.2k stars 490 forks source link

Add sleep before shutdown backup container (#5454) #5606

Closed ti-chi-bot closed 3 months ago

ti-chi-bot commented 3 months ago

This is an automated cherry-pick of #5454

What problem does this PR solve?

Add sleep before shutdown backup container

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

BornChanger commented 3 months ago

/retest

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.52%. Comparing base (724031b) to head (1270aa3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.5 #5606 +/- ## =============================================== + Coverage 61.54% 64.52% +2.97% =============================================== Files 229 242 +13 Lines 29331 33297 +3966 =============================================== + Hits 18052 21484 +3432 - Misses 9498 9950 +452 - Partials 1781 1863 +82 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5606/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5606/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `34.12% <ø> (?)` | | | [unittest](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5606/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.53% <ø> (-0.01%)` | :arrow_down: |
BornChanger commented 3 months ago

/run-pull-e2e-kind

ti-chi-bot[bot] commented 3 months ago

[LGTM Timeline notifier]

Timeline:

BornChanger commented 3 months ago

/merge

ti-chi-bot[bot] commented 3 months ago

@BornChanger: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
BornChanger commented 3 months ago

/approve

ti-chi-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb-operator/blob/release-1.5/OWNERS)~~ [BornChanger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment