Add 10s sleep prior to warmup exit for sidecars to upload logs (#5599)

ti-chi-bot commented 3 months ago

This is an automated cherry-pick of #5599

What problem does this PR solve?

Add sleep before exiting the warmup container. This is needed to give time to sidecar containers to upload logs/metrics before warmup completes.

What is changed and how does it work?

Code changes

[ ] Has Go code change
[ ] Has CI related scripts change

Tests

[ ] Unit test
[ ] E2E test
[x] Manual test

Ran EBS snapshot restore w/ updated warmup pod and observe restore functions as expected.

[ ] No code

Side effects

[ ] Breaking backward compatibility
[ ] Other side effects:

Related changes

[ ] Need to cherry-pick to the release branch
[ ] Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

ti-chi-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign hanlins for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tidb-operator/blob/release-1.5/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.55%. Comparing base (4fd903f) to head (8222280).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release-1.5 #5607 +/- ## =============================================== + Coverage 61.53% 61.55% +0.01% =============================================== Files 229 229 Lines 29331 29331 =============================================== + Hits 18050 18054 +4 + Misses 9499 9497 -2 + Partials 1782 1780 -2 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5607/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5607/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.55% <ø> (+0.01%)` | :arrow_up: |

pingcap / tidb-operator