pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.22k stars 497 forks source link

[BR] add pv name in restore EBS vol #5612

Closed wxiaomou closed 5 months ago

wxiaomou commented 5 months ago

What problem does this PR solve?

What is changed and how does it work?

""kubernetes.io/created-for/pv/name" tag is a common ebs tag added by CSI driver, current restore EBS vol does not have it . Added in this PR. https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/driver/controller_test.go#L1551

Code changes

Tests

Side effects

Related changes

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

ti-chi-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb-operator/blob/master/OWNERS)~~ [BornChanger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BornChanger commented 5 months ago

/retest

BornChanger commented 5 months ago

/cherry-pick-for-release-1.5

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.25%. Comparing base (72bccb5) to head (f9cfa89). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5612 +/- ## =========================================== - Coverage 61.49% 46.25% -15.24% =========================================== Files 235 219 -16 Lines 30337 30197 -140 =========================================== - Hits 18655 13969 -4686 - Misses 9813 14555 +4742 + Partials 1869 1673 -196 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5612/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5612/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `46.25% <0.00%> (?)` | | | [unittest](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5612/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | |
wxiaomou commented 5 months ago

/retest

ti-chi-bot[bot] commented 5 months ago

@wxiaomou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb-operator/pull/5612#issuecomment-2051001851): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 5 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 5 months ago

New changes are detected. LGTM label has been removed.

csuzhangxc commented 5 months ago

/cherry-pick release-1.5

ti-chi-bot commented 5 months ago

@csuzhangxc: new pull request created to branch release-1.5: #5615.

In response to [this](https://github.com/pingcap/tidb-operator/pull/5612#issuecomment-2056179381): >/cherry-pick release-1.5 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.