pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.2k stars 490 forks source link

support setting extra command line arguments for TiDB #5624

Closed csuzhangxc closed 2 months ago

csuzhangxc commented 2 months ago

What problem does this PR solve?

close #5625

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

support setting extra command line arguments for TiDB
ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tidb-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
csuzhangxc commented 2 months ago

/run-all-tests

csuzhangxc commented 2 months ago

/run-pull-e2e-kind-basic

csuzhangxc commented 2 months ago

/run-pull-e2e-kind-across-kubernetes

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 48.03%. Comparing base (3897095) to head (6a11185).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5624 +/- ## =========================================== - Coverage 61.46% 48.03% -13.43% =========================================== Files 235 219 -16 Lines 30397 30216 -181 =========================================== - Hits 18683 14515 -4168 - Misses 9840 13959 +4119 + Partials 1874 1742 -132 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5624/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `48.03% <71.42%> (?)` | | | [unittest](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | |
csuzhangxc commented 2 months ago

/run-pull-e2e-kind-serial

csuzhangxc commented 2 months ago

/run-pull-e2e-kind-tngm