Closed ideascf closed 1 month ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: csuzhangxc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-05-16 03:49:55.671626204 +0000 UTC m=+1711549.428761774
: :ballot_box_with_check: agreed by csuzhangxc./run-all-tests
Attention: Patch coverage is 50.00000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 30.57%. Comparing base (
3897095
) to head (cfb9dc2
). Report is 6 commits behind head on master.
/run-pull-e2e-kind-across-kubernetes
/run-pull-e2e-kind-basic
/run-pull-e2e-kind-br
/run-pull-e2e-kind-serial
What problem does this PR solve?
Currently, we have no ability to check whether the STS is already updated with the latest TC.spec.{component}. But for some scenarios, we want to know whether is a STS successfully updated. Therefore, this PR introduces a new annotation
tidb.pingcap.com/owner-generation
to store the generation of its owner into STS's annotation.What is changed and how does it work?
Code changes
Tests
[ ] Unit test
[ ] E2E test
[x] Manual test
[ ] No code
create a cluster with old tidb-operator
deploy new tidb-operator, components of this cluster shouldn't restart and all STSs shouldn't be annotated with that annotation
scale tidb out, that annotation should be annotated into STS db-tidb and the old tidb pod shouldn't be restarted.
scale tidb in, that annotation should be annotated into STS db-tidb and the another one tidb pod shouldn't be restarted.
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.