pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.2k stars 490 forks source link

[BR]initialize status metric to zero (#5637) #5648

Closed ti-chi-bot closed 1 month ago

ti-chi-bot commented 1 month ago

This is an automated cherry-pick of #5637

What problem does this PR solve?

Currently when the federated manager restart we lost the metrics, and the new status metric will start with value 1. In our dashboard we are measuring success/fail backups by increase() function, current implementation will cause we lost the back up status when federated manager restarts.

This PR set the status counter to 0 before it emit the first metric.

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tennix for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tidb-operator/blob/release-1.5/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment