ebs br: enhance TC validation

BornChanger commented 4 weeks ago

What problem does this PR solve?

Closes #5658

What is changed and how does it work?

For volume backup, this PR enhances the validation against the target TiDB cluster. That is if there is no TiKV stores or TiKV replica number is 0, the backup will fail.

Code changes

[x] Has Go code change
[ ] Has CI related scripts change

Tests

[x] Unit test
[ ] E2E test
[ ] Manual test
[ ] No code

Side effects

[ ] Breaking backward compatibility
[ ] Other side effects:

Related changes

[ ] Need to cherry-pick to the release branch
[ ] Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

BornChanger commented 4 weeks ago

/cc @WangLe1321

BornChanger commented 4 weeks ago

/cc @YuJuncen

ti-chi-bot[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb-operator/blob/master/OWNERS)~~ [WangLe1321] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 3 weeks ago

[LGTM Timeline notifier]

Timeline:

2024-06-06 13:17:54.593965874 +0000 UTC m=+38628.647277797: :ballot_box_with_check: agreed by WangLe1321.
2024-06-09 12:28:29.346139988 +0000 UTC m=+294863.399451913: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].

ti-chi-bot[bot] commented 3 weeks ago

New changes are detected. LGTM label has been removed.

BornChanger commented 3 weeks ago

/run-pull-e2e-kind-br

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 21.07%. Comparing base (3897095) to head (f044720). Report is 12 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #5659 +/- ## =========================================== - Coverage 61.46% 21.07% -40.39% =========================================== Files 235 219 -16 Lines 30397 30427 +30 =========================================== - Hits 18683 6412 -12271 - Misses 9840 23103 +13263 + Partials 1874 912 -962 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5659/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `21.07% <33.33%> (?)` | | | [unittest](https://app.codecov.io/gh/pingcap/tidb-operator/pull/5659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | |

csuzhangxc commented 3 weeks ago

/cherry-pick release-1.5

csuzhangxc commented 3 weeks ago

/cherry-pick release-1.6

ti-chi-bot commented 3 weeks ago

@csuzhangxc: new pull request created to branch release-1.5: #5662.

In response to [this](https://github.com/pingcap/tidb-operator/pull/5659#issuecomment-2162071107): >/cherry-pick release-1.5 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

ti-chi-bot commented 3 weeks ago

@csuzhangxc: new pull request created to branch release-1.6: #5663.

In response to [this](https://github.com/pingcap/tidb-operator/pull/5659#issuecomment-2162071198): >/cherry-pick release-1.6 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

pingcap / tidb-operator