Closed rajsuvariya closed 1 week ago
/run-pull-e2e-kind
/run-pull-e2e-kind
/run-pull-e2e-kind
Attention: Patch coverage is 0%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 39.54%. Comparing base (
9ef26f8
) to head (7a7be53
). Report is 1 commits behind head on master.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: csuzhangxc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-06-27 01:53:36.752478118 +0000 UTC m=+857343.237966943
: :ballot_box_with_check: agreed by csuzhangxc./cherry-pick release-1.5
/cherry-pick release-1.6
@csuzhangxc: new pull request created to branch release-1.5
: #5671.
@csuzhangxc: new pull request created to branch release-1.6
: #5672.
What problem does this PR solve?
https://github.com/pingcap/tidb-operator/blob/9ef26f88bf75338cef427b44aa6303237ddcdbd6/pkg/features/features.go#L55C9-L57C44 PVC replace feature is currently enabled / disabled at tidb-operator level, which might not be comforting situation as a single tidb-operator can be handling multiple tidbclusters, so this PR enables tidbcluster level flag to enable / disable this feature. This is similar to another similar feature
enablePVReclaim
flagWhat is changed and how does it work?
Added a new flag in CRD
enablePVCReplace
with a false as default value. If this flag is enabled then only tidb-operator would perform the PVC replacement process.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.