Closed ti-chi-bot closed 1 week ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: csuzhangxc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-06-27 08:00:29.190552601 +0000 UTC m=+879355.676041434
: :ballot_box_with_check: agreed by csuzhangxc.
This is an automated cherry-pick of #5670
What problem does this PR solve?
https://github.com/pingcap/tidb-operator/blob/9ef26f88bf75338cef427b44aa6303237ddcdbd6/pkg/features/features.go#L55C9-L57C44 PVC replace feature is currently enabled / disabled at tidb-operator level, which might not be comforting situation as a single tidb-operator can be handling multiple tidbclusters, so this PR enables tidbcluster level flag to enable / disable this feature. This is similar to another similar feature
enablePVReclaim
flagWhat is changed and how does it work?
Added a new flag in CRD
enablePVCReplace
with a false as default value. If this flag is enabled then only tidb-operator would perform the PVC replacement process.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.