pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.24k stars 499 forks source link

Support Azure Volume based snapshot for backups #5716

Open viniciusvarzea opened 2 months ago

viniciusvarzea commented 2 months ago

Feature Request

Is your feature request related to a problem? Please describe:

Describe the feature you'd like: Tidb running on Aws Kubernetes are able to backup using EBS volume snapshots. May you guys please make this feature available on azure aks ?

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

https://learn.microsoft.com/en-us/azure/virtual-machines/disks-incremental-snapshots?tabs=azure-cli

csuzhangxc commented 2 months ago

sorry, we have no plan to support snapshot backup on azure AKS currently.

viniciusvarzea commented 1 month ago

I am a very skilled software engineer, I am willing to implement this feature, maybe you guys can use it in the future. May you guys please share some documentation’s about how it is implemented in AWS ? It will be a great start point for me.

Thank you guys, you guys do a really good jog at TiDB.

BornChanger commented 1 month ago

@viniciusvarzea thanks a lot for your passion to be willing to contribute to this feature. so far, we provide ebs snapshot br support to aws only. and it's a solution with heavy operator. Refer to issue https://github.com/pingcap/tidb-operator/issues/5003. From rpo & rto perspective, the solution is not necessarily better than our new snapshot backup and restore. so, we don't want to spend more effort to that feature.