search

pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.22k stars 493 forks source link

AWS deployment requires terraform >= 0.12 #635

Closed sokada1221 closed 5 years ago

sokada1221 commented 5 years ago

Bug Report

What version of Kubernetes are you using? N/A

What version of TiDB Operator are you using? latest master

What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods? N/A

What's the status of the TiDB cluster pods? N/A

What did you do?

  1. Checkout latest tidb-operator
  2. terraform apply from deploy/aws

What did you expect to see? Successful deployment according to the README terraform version requirement should be documented

What did you see instead? Parsing error from terraform due to first-class expression syntax. For example, in deploy/aws/bastion.tf, following lines will not work with terraform versions v0.11 and lower:

  vpc_id      = var.create_vpc ? module.vpc.vpc_id : var.vpc_id
  instance_count              = var.create_bastion ? 1 : 0

Looks like this feature was introduced in terraform v0.12.

sokada1221 commented 5 years ago

@aylei FYI - seems like a new requirement from https://github.com/pingcap/tidb-operator/pull/616

Edit: Quickly updated the README to reflect the current state. I personally think this new requirement is okay but I'll leave the design decision on whether older terraform versions should be supported or not to PingCAP.

gregwebs commented 5 years ago

closed by #636