search

pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.
https://docs.pingcap.com/tidb-in-kubernetes/
Apache License 2.0
1.22k stars 493 forks source link

Do not set --capacity to tikv-server if resources.limits.storage is not given #944

Closed cofyc closed 4 years ago

cofyc commented 4 years ago

Feature Request

Is your feature request related to a problem? Please describe:

Currently, we cannot set raftstore.capacity in TiKV configuration.

https://github.com/pingcap/tidb-operator/blob/761daab5900d98959cd58762690bdfcce2432193/charts/tidb-cluster/values.yaml#L209

Describe the feature you'd like:

Do not pass TiKV default value if resources.limits.storage is absent. This will make it possible for users to set capacity in TiKV configuration.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

xref: https://github.com/pingcap/tidb-operator/pull/868 https://github.com/pingcap/tidb-operator/pull/942

cofyc commented 4 years ago

cc @weekface @tennix what do you think?

weekface commented 4 years ago

It's fine with me.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days