search

pingcap / tidb-tools

tidb-tools are some useful tool collections for TiDB.
Apache License 2.0
286 stars 191 forks source link

sync_diff_inspector: add sum aggregate #686

Open Leavrth opened 1 year ago

Leavrth commented 1 year ago

What problem does this PR solve?

Issue Number: ref #634

What is changed and how it works?

we can choose SUM as the aggregate operator instead of BIT_XOR.

Check List

Tests

ti-chi-bot commented 1 year ago

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lance6716 commented 1 year ago

rest lgtm

ti-chi-bot commented 1 year ago

@Leavrth: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.