pingcap / tidb-tools

tidb-tools are some useful tool collections for TiDB.
Apache License 2.0
288 stars 193 forks source link

sync-diff-inspector: support base64 encoded password #688

Closed lichunzhu closed 1 year ago

lichunzhu commented 1 year ago

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb-tools/issues/687

What is changed and how it works?

support base64 encoded password like lightning did in https://github.com/pingcap/tidb/pull/31195

Check List

Tests

Code changes

Side effects

Related changes

ti-chi-bot commented 1 year ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lichunzhu commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

This pull request has been accepted and is ready to merge.

Commit hash: 4f18250e1e2eb6b65015897b0a87791ee1976202