sync-diff-inspector: skip validation for tables that exist only upstream or downstream and print skipped information in summary and progress

pingcap / tidb-tools

tidb-tools are some useful tool collections for TiDB.

Apache License 2.0

288 stars 193 forks source link

sync-diff-inspector: skip validation for tables that exist only upstream or downstream and print skipped information in summary and progress #693

Closed liumengya94 closed 1 year ago

liumengya94 commented 1 year ago

What problem does this PR solve?

Issue Number: ref #692

What is changed and how it works?

Add parameter skip-non-existing-table, which defaults to false.
Record and skip validation for tables that exist only upstream or downstream.
Show skipped information and row count comparison for missing tables in summary.txt.
Print progress information about skipped tables.

Check List

Tests

Unit test
Integration test

Code changes

Has exported function/method change
Has exported variable/fields change

Side effects

None

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to be included in the release note

ti-chi-bot commented 1 year ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

CLAassistant commented 1 year ago

All committers have signed the CLA.

liumengya94 commented 1 year ago

/run-all-tests

liumengya94 commented 1 year ago

/cc @lichunzhu

lichunzhu commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

This pull request has been accepted and is ready to merge.

Commit hash: 8d7c34361c98e26563a071f394a701df9b4ca28c

ti-chi-bot commented 1 year ago

@liumengya94: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

liumengya94 commented 1 year ago

/run-unit-test