pingcap / tidb-tools

tidb-tools are some useful tool collections for TiDB.
Apache License 2.0
286 stars 191 forks source link

sync_diff: fix hidden column #712

Closed okJiang closed 1 year ago

okJiang commented 1 year ago

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb-tools/issues/713

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

ti-chi-bot commented 1 year ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
lance6716 commented 1 year ago

@okJiang Can you add a test, or manually test it?

okJiang commented 1 year ago

@okJiang Can you add a test, or manually test it?

This PR has not yet solved this issue, and it has been manually tested.

@Leavrth will take a look for this in Friday

ti-chi-bot commented 1 year ago

@YangKeao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to [this](https://github.com/pingcap/tidb-tools/pull/712#pullrequestreview-1364361662): >LGTM Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
YangKeao commented 1 year ago

I think https://github.com/pingcap/tidb-tools/pull/715 is part of it, so you need to resolve the conflict.

Leavrth commented 1 year ago

the index having expression is not support for binary search, bucket split and random split features in sync-diff-inspector. So ignore this kind of the index when build splitter.

(However, sync-diff-inspector doesn't compare the index kvs.

okJiang commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

@okJiang: /merge in this pull request requires 1 approval(s).

In response to [this](https://github.com/pingcap/tidb-tools/pull/712#issuecomment-1501593939): >/merge Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
Leavrth commented 1 year ago

/merge

ti-chi-bot commented 1 year ago

This pull request has been accepted and is ready to merge.

Commit hash: d7a5efd9a3ff08f4222b39496c54ceada003aa2f