Closed okJiang closed 1 year ago
[REVIEW NOTIFICATION]
This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer
in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer
in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
@okJiang Can you add a test, or manually test it?
@okJiang Can you add a test, or manually test it?
This PR has not yet solved this issue, and it has been manually tested.
@Leavrth will take a look for this in Friday
@YangKeao: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.
I think https://github.com/pingcap/tidb-tools/pull/715 is part of it, so you need to resolve the conflict.
the index having expression is not support for binary search
, bucket split
and random split
features in sync-diff-inspector.
So ignore this kind of the index when build splitter.
(However, sync-diff-inspector doesn't compare the index kvs.
/merge
@okJiang: /merge
in this pull request requires 1 approval(s).
/merge
This pull request has been accepted and is ready to merge.
What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tidb-tools/issues/713
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes