pingcap / tidb-tools

tidb-tools are some useful tool collections for TiDB.
Apache License 2.0
287 stars 192 forks source link

sync-diff-inspector: fix error when json column is NULL #737

Closed Leavrth closed 1 year ago

Leavrth commented 1 year ago

What problem does this PR solve?

Issue Number: close #736

What is changed and how it works?

check whether the json column is NULL to avoid json unmarshal error.

Check List

Tests

Release Note

None
ti-chi-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb-tools/blob/master/OWNERS)~~ [3pointer] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 year ago

[LGTM Timeline notifier]

Timeline:

Leavrth commented 1 year ago

/merge

ti-chi-bot[bot] commented 1 year ago

@Leavrth: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
Leavrth commented 1 year ago

/tide