pingcap / tidb-tools

tidb-tools are some useful tool collections for TiDB.
Apache License 2.0
287 stars 192 forks source link

add incompatibleEvent for binlog filter #747

Closed GMHDBJD closed 1 year ago

GMHDBJD commented 1 year ago

What problem does this PR solve?

Issue Number: ref #596 https://github.com/pingcap/tiflow/issues/9850

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

Release Note

None
ti-chi-bot[bot] commented 1 year ago

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

ti-chi-bot[bot] commented 1 year ago

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 1 year ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tidb-tools/pull/747#pullrequestreview-1666550210): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: okJiang Once this PR has been reviewed and has the lgtm label, please ask for approval from gmhdbjd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tidb-tools/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment