add drop column, rename column/index for incompatible ddl changes

pingcap / tidb-tools

tidb-tools are some useful tool collections for TiDB.

Apache License 2.0

286 stars 191 forks source link

add drop column, rename column/index for incompatible ddl changes #751

Closed GMHDBJD closed 10 months ago

GMHDBJD commented 10 months ago

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb-tools/issues/596 https://github.com/pingcap/tiflow/issues/9850

What is changed and how it works?

add drop column
add rename column
add rename index
regard DropDatabase,DropTable,DropIndex,RenameTable,TruncateTable,DropSchema,DropTablePartition,TruncateTablePartition as incompatible ddls

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to be included in the release note

ti-chi-bot[bot] commented 10 months ago

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

GMHDBJD commented 10 months ago

/retest

GMHDBJD commented 10 months ago

/run-unit-test

ti-chi-bot[bot] commented 10 months ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tidb-tools/pull/751#pullrequestreview-1705611338): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ti-chi-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lichunzhu, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb-tools/blob/master/OWNERS)~~ [lichunzhu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 10 months ago

[LGTM Timeline notifier]

Timeline:

2023-10-31 07:34:38.272382312 +0000 UTC m=+2938475.859492458: :ballot_box_with_check: agreed by lichunzhu.
2023-10-31 07:34:54.20139536 +0000 UTC m=+2938491.788505505: :heavy_multiplication_x::repeat: reset by GMHDBJD.
2023-10-31 07:40:04.016302574 +0000 UTC m=+2938801.603412718: :ballot_box_with_check: agreed by lichunzhu.