search

pingcap / tidb-tools

tidb-tools are some useful tool collections for TiDB.
Apache License 2.0
286 stars 190 forks source link

sync_diff_inspector: Improve startup errors #793

Closed dveeden closed 2 months ago

dveeden commented 3 months ago

What problem does this PR solve?

Issue Number: close #792

What is changed and how it works?

Before:

$ ./bin/sync_diff_inspector --config ./sync-diff.conf 
There is something error when initialize diff, please check log info in output/sync_diff.log

After:

$ ./bin/sync_diff_inspector --config ./sync-diff.conf 
An error occured while initializing diff: no table need to be compared, please check log info in output/sync_diff.log for full details

Check List

Tests

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb-tools/blob/master/OWNERS)~~ [Leavrth] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 months ago

[LGTM Timeline notifier]

Timeline: