search

pingcap / tidb-tools

tidb-tools are some useful tool collections for TiDB.
Apache License 2.0
286 stars 190 forks source link

sync-diff-inspector: Compatibility with MySQL 8.4.0 #794

Open dveeden opened 3 months ago

dveeden commented 3 months ago

Feature Request

MySQL 8.4.0 is a LTS release that has removed some deprecated commands and variables like SHOW MASTER STATUS. It looks like sync-diff-inspector is using some of this and needs to be updated.

https://github.com/pingcap/tidb-tools/blob/a005a9426f5bd82664907b97344f4255fc8608b1/sync_diff_inspector/utils/pd.go#L271

https://github.com/pingcap/tidb-tools/blob/a005a9426f5bd82664907b97344f4255fc8608b1/pkg/dbutil/common.go#L649

https://github.com/pingcap/tidb-tools/blob/a005a9426f5bd82664907b97344f4255fc8608b1/tests/sync_diff_inspector/snapshot/run.sh#L15