Open SunRunAway opened 4 years ago
I want to do some executors for this.
I want to do some executors for this.
Thanks, I've been investigating inline projection for planner and join parts(#14428). I hope I can finish them in these two days, so that you guys can continue to do works for other executors.
Hi, I want to help to implement this for Merge Join, is it available now? @Reminiscent @SunRunAway
Hi, I want to help to implement this for Merge Join, is it available now? @Reminiscent @SunRunAway
Yes. That's great. Looking forward to your PR.
Hi, I managed to pass tests in #15463, PTAL at your convenience.
I'm going to take Selection, but I didn't know what should I do. Seems that LogicalSelection
has already did PruneColumns
for its child, there's no reduntant columns which need to do inlineProjection
. (BTW, I didn't find where schema of LogicalSelection
is set, not familiar with these code 😄 )
/pick-up limit
Pick up success.
Maybe individual issue should be created for each item
/give-up
Give up success.
/pick-up Sort and TopN
Pick up success.
@hidehalo You did not submit PR within 7 days, so give up automatically.
/pick-up
Pick up success.
@SunRunAway PTAL #19900 👀
/pick-up Limit
This issue already picked by hidehalo.
@hidehalo You did not submit PR within 7 days, so give up automatically.
/pick-up
Pick up success.
@SunRunAway I' confusing about the inline projection for Limit. Does it means
select t1.b+1 from t1 limit 3
?
btw
could you please give me more explaition about inline projection. I cannot find it in google.
@SunRunAway I' confusing about the inline projection for Limit. Does it means
select t1.b+1 from t1 limit 3
?
btw
could you please give me more explaition about inline projection. I cannot find it in google.
That's almost right and the top Projection can also be pruned.
And here's a slide for introducing https://docs.google.com/presentation/d/1cjdMjKFMbmQdIaDvTKBHlT9TXcqGJUjgkeylrseTrx8/edit#slide=id.p
@pengdaqian2020 You did not submit PR within 7 days, so give up automatically.
/pick-up Apply
The challenge program issue is already in the assign flow, so you cannot pick up this issue. But the current issue needs help, you can contact @SunRunAway to try to solve this issue together.
@YangKian you can ignore the bot's message and you can still do this issue and get points if your pr is merged.
@SunRunAway Thanks for reminding~ I'd like to have some try :P
Description
Is your feature request related to a problem? Please describe:
For example,
Join executor reads
t1.a
andt1.b
from tablet1
,t2.a
from tablet2
, then concatenates and materilizes these three columns. Next step, projection executor projects three columns to one column oft1.b
.Describe the feature you'd like:
We can optimize it by set the output schema of Join executor as only
t1.b
, so that the executor do know that it only need to outputt1.b
. It can avoid copyingt1.a
andt2.a
which are not needed by its parent when materilizes/copys data buffers.Here's a demostration PR to show how the performance we gain from avoiding copying extra columns for SORT executor.
What we need to do:
Difficulty
Score
Mentor(s)
Recommended Skills