pingcap / tidb

TiDB - the open-source, cloud-native, distributed SQL database designed for modern applications.
https://pingcap.com
Apache License 2.0
37.41k stars 5.85k forks source link

blocking issues at `TestT of` owner/manager_test.go #27002

Closed charlesxsh closed 10 months ago

charlesxsh commented 3 years ago

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Run the test TestT of owner/manager_test.go.

2. What did you expect to see? (Required)

no blocking issue during/at the exit of testing.

3. What did you see instead (Required)

The blocking issues at

github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:464

func (tracker *resultTracker) _loopRoutine() {
    for {
        var c *C
        if tracker._waiting > 0 {
            // Calls still running. Can't stop.
            select {    <-------- line 464
            // XXX Reindent this (not now to make diff clear)
            case c = <-tracker._expectChan:
                tracker._waiting += 1
            case c = <-tracker._doneChan:
                tracker._waiting -= 1

github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:667

func (runner *suiteRunner) doRun(c *C) {
    if c == nil || c.status() == succeededSt {
        var delayedC []*C

        for i := 0; i != len(runner.tests); i++ {
            c := runner.forkTest(runner.tests[i])
            select {     <------ line 667
            case <-c.done:
            case <-c.parallel:
                delayed

4. What is your TiDB version? (Required)

commit b8107d7

These blocking issues might or might not directly caused by the usages of third party libraries, please take a look and redirect to the corresponding repository if possible, thanks.

charlesxsh commented 3 years ago

Hi there, kindly ask do we have any update on this PR?

Defined2014 commented 10 months ago

The code has changed a lot and TestT already be removed by https://github.com/pingcap/tidb/pull/26715, so close this issue.