ti-chi-bot
commented
2 years ago [REVIEW NOTIFICATION]
This pull request has been approved by:
- wjhuang2016
- zimulala
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.
sre-bot
hawkingrei
wjhuang2016
purelind
xiongjiwei
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com Signed-off-by: xiongjiwei xiongjiwei1996@outlook.com Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: ref https://github.com/pingcap/tidb/issues/32031
this is a big PR and we split it into many commits, every commit almost has a single purpose. I will introduce them briefly, you may need to reference the doc https://github.com/pingcap/tidb/pull/33629
init ddl tables create
tidb_ddl_job,tidb_ddl_reorg,tidb_ddl_historytables with raw meta write, these 3 tables is use to replace theddl job queueandreorgandhistory hash table. you can see this part in docsetup concurrent ddl env and add ddl worker pool this commit adds the
ddl worker pooldefinition, theddl job managerwill find a job and ship it to a worker in the worker pool. Also, this commit provides asessionctxwrapper, only use in ddl relate. it just wrapsbegin,commitandexecute.add ddl manager to handle ddl job this commit implements the ddl manager, which is used for
you can ref the doc. Also, it adds a function
HandleDDLJobwhich will do the ddl job, and it is a replacer ofHandleDDLJobQueue. The last thing of this commit is addingschemaVersionManagerto update the schema version in a new txn, it prevents the txn conflict with the schema version key.reorg handler for concurrent ddl just implements the partner of the reorg information.
manage ddl jobs for concurrent ddl same as above, the partner of
add job,delete joband many other related to history jobchange ddl interface caller because many of the functions need a session now, we just change the caller
add metrics for concurrent ddl add metrics
migrate ddl between table and queue support switch between the old and new ddl framework, migrate the existing ddl job between queue and table
What is changed and how it works?
Check List
Tests
Release note