lightning: improve post-import conflict detection 'error' semantic

lyzx2001 commented 4 months ago

What problem does this PR solve?

Issue Number: ref #51036

Problem Summary: Merge preprocess duplicate detection and post-import conflict detection.

What changed and how does it work?

Improve post-import conflict detection 'error' semantic.

Check List

Tests

[x] Unit test
[x] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test
- [ ] I checked and no code files have been changed.

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow[bot] commented 3 months ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/51277#issuecomment-1987903615): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 3 months ago

/cc @GMHDBJD @Leavrth @ywqzzy

lyzx2001 commented 3 months ago

/test pull-lightning-integration-test

tiprow[bot] commented 3 months ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/51277#issuecomment-1988625274): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 3 months ago

/cc @D3Hunter

lyzx2001 commented 3 months ago

/test pull-lightning-integration-test

tiprow[bot] commented 3 months ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/51277#issuecomment-1990761238): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 3 months ago

/retest

tiprow[bot] commented 3 months ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/51277#issuecomment-1990906782): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 3 months ago

/retest

tiprow[bot] commented 3 months ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/51277#issuecomment-1990918636): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 3 months ago

/test pull-lightning-integration-test

tiprow[bot] commented 3 months ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/51277#issuecomment-1991181367): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 3 months ago

/test pull-lightning-integration-test

tiprow[bot] commented 3 months ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/51277#issuecomment-1993526726): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 3 months ago

/test pull-lightning-integration-test

tiprow[bot] commented 3 months ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/51277#issuecomment-1993703649): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 3 months ago

/test pull-lightning-integration-test

tiprow[bot] commented 3 months ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/51277#issuecomment-1993833331): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ti-chi-bot[bot] commented 3 months ago

[LGTM Timeline notifier]

Timeline:

2024-03-12 02:47:13.298313837 +0000 UTC m=+740060.320560226: :ballot_box_with_check: agreed by Leavrth.
2024-03-13 09:07:50.835466181 +0000 UTC m=+849297.857712554: :ballot_box_with_check: agreed by zimulala.

lyzx2001 commented 3 months ago

/test pull-lightning-integration-test

tiprow[bot] commented 3 months ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/51277#issuecomment-1993956329): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ti-chi-bot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Leavrth, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb/blob/master/OWNERS)~~ [D3Hunter,Leavrth,zimulala] - ~~[br/OWNERS](https://github.com/pingcap/tidb/blob/master/br/OWNERS)~~ [Leavrth] - ~~[br/pkg/lightning/OWNERS](https://github.com/pingcap/tidb/blob/master/br/pkg/lightning/OWNERS)~~ [D3Hunter] - ~~[pkg/ddl/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/ddl/OWNERS)~~ [zimulala] - ~~[pkg/executor/importer/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/executor/importer/OWNERS)~~ [D3Hunter] - ~~[pkg/table/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/table/OWNERS)~~ [zimulala] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tidb