search

pingcap / tidb

TiDB is an open-source, cloud-native, distributed, MySQL-Compatible database for elastic scale and real-time analytics. Try AI-powered Chat2Query free at : https://www.pingcap.com/tidb-serverless/
https://pingcap.com
Apache License 2.0
36.55k stars 5.75k forks source link

index out of range [-1] in `(*expressionRewriter).inToExpression` #52769

Open GaranR opened 2 months ago

GaranR commented 2 months ago

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

First execute the following valid.sql valid.txt

Then a crash occurs when executing the error.sql below error4.txt

2. What did you expect to see? (Required)

Expect no crashes

3. What did you see instead (Required)

runtime error: index out of range [-1]

tidb.log:

[2024/04/17 11:57:26.623 +00:00] [ERROR] [conn.go:990] ["connection running loop panic"] [conn=408946066] [session_alias=] [lastSQL="(check error.sql above)"] [err="runtime error: index out of range [-1]"] [stack="github.com/pingcap/tidb/pkg/server.(*clientConn).Run.func1
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/server/conn.go:993
runtime.gopanic
    /usr/local/go/src/runtime/panic.go:914
github.com/pingcap/tidb/pkg/executor.(*Compiler).Compile.func1
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/executor/compiler.go:54
runtime.gopanic
    /usr/local/go/src/runtime/panic.go:914
runtime.goPanicIndex
    /usr/local/go/src/runtime/panic.go:114
github.com/pingcap/tidb/pkg/planner/core.(*expressionRewriter).inToExpression
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:1656
github.com/pingcap/tidb/pkg/planner/core.(*expressionRewriter).Leave
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:1328
github.com/pingcap/tidb/pkg/parser/ast.(*PatternInExpr).Accept
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/parser/ast/expressions.go:770
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).rewriteExprNode
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:201
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).rewriteWithPreprocess
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:146
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).rewrite
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:114
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).buildSelection
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/logical_plan_builder.go:1393
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).buildSelect
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/logical_plan_builder.go:4516
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).buildResultSetNode
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/logical_plan_builder.go:573
github.com/pingcap/tidb/pkg/planner/core.(*expressionRewriter).buildSubquery
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:350
github.com/pingcap/tidb/pkg/planner/core.(*expressionRewriter).handleExistSubquery
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:841
github.com/pingcap/tidb/pkg/planner/core.(*expressionRewriter).Enter
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:395
github.com/pingcap/tidb/pkg/parser/ast.(*ExistsSubqueryExpr).Accept
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/parser/ast/expressions.go:672
github.com/pingcap/tidb/pkg/parser/ast.(*ParenthesesExpr).Accept
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/parser/ast/expressions.go:1016
github.com/pingcap/tidb/pkg/parser/ast.(*BinaryOperationExpr).Accept
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/parser/ast/expressions.go:217
github.com/pingcap/tidb/pkg/parser/ast.(*BinaryOperationExpr).Accept
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/parser/ast/expressions.go:217
github.com/pingcap/tidb/pkg/parser/ast.(*ParenthesesExpr).Accept
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/parser/ast/expressions.go:1016
github.com/pingcap/tidb/pkg/parser/ast.(*FuncCastExpr).Accept
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/parser/ast/functions.go:669
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).rewriteExprNode
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:201
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).rewriteWithPreprocess
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:146
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).rewrite
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/expression_rewriter.go:114
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).buildAggregation
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/logical_plan_builder.go:370
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).buildSelect
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/logical_plan_builder.go:4570
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).buildResultSetNode
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/logical_plan_builder.go:573
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).buildCte
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/logical_plan_builder.go:7697
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).buildWith
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/logical_plan_builder.go:7948
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).buildSelect
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/logical_plan_builder.go:4436
github.com/pingcap/tidb/pkg/planner/core.(*PlanBuilder).Build
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/core/planbuilder.go:859
github.com/pingcap/tidb/pkg/planner.buildLogicalPlan
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/optimize.go:576
github.com/pingcap/tidb/pkg/planner.optimize
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/optimize.go:494
github.com/pingcap/tidb/pkg/planner.Optimize
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/planner/optimize.go:352
github.com/pingcap/tidb/pkg/executor.(*Compiler).Compile
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/executor/compiler.go:98
github.com/pingcap/tidb/pkg/session.(*session).ExecuteStmt
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/session/session.go:2221
github.com/pingcap/tidb/pkg/server.(*TiDBContext).ExecuteStmt
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/server/driver_tidb.go:292
github.com/pingcap/tidb/pkg/server.(*clientConn).handleStmt
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/server/conn.go:2064
github.com/pingcap/tidb/pkg/server.(*clientConn).handleQuery
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/server/conn.go:1831
github.com/pingcap/tidb/pkg/server.(*clientConn).dispatch
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/server/conn.go:1318
github.com/pingcap/tidb/pkg/server.(*clientConn).Run
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/server/conn.go:1091
github.com/pingcap/tidb/pkg/server.(*Server).onConn
    /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tidb/pkg/server/server.go:715"]

4. What is your TiDB version? (Required)

+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tidb_version()                                                                                                                                                                                                                                                 |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Release Version: v7.5.1
Edition: Community
Git Commit Hash: 7d16cc79e81bbf573124df3fd9351c26963f3e70
Git Branch: heads/refs/tags/v7.5.1
UTC Build Time: 2024-02-27 14:28:32
GoVersion: go1.21.6
Race Enabled: false
Check Table Before Drop: false
Store: tikv |
+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

We are the BASS team from the School of Cyber Science and Technology at Beihang University. Our main focus is on system software security, operating systems, and program analysis research, as well as the development of automated program testing frameworks for detecting software defects. Using our self-developed database vulnerability testing tool, we have identified the above-mentioned vulnerabilities in TiDB that may lead to database crashes.

qw4990 commented 1 month ago

Degrade this case from Major to Moderate since it's too extreme (48 CTEs and more than 2600 lines), not common