pingcap / tidb

TiDB is an open-source, cloud-native, distributed, MySQL-Compatible database for elastic scale and real-time analytics. Try AI-powered Chat2Query free at : https://tidbcloud.com/free-trial
https://pingcap.com
Apache License 2.0
36.27k stars 5.72k forks source link

br/operator: fix adapt env for snapshot backup stuck when encountered error (#52607) #52970

Closed ti-chi-bot closed 1 week ago

ti-chi-bot commented 2 weeks ago

This is an automated cherry-pick of #52607

What problem does this PR solve?

Issue Number: close #52846

Problem Summary: When we failed to prepare the connections for wait apply, the channel may never be closed. Hence the pause PD operation (which relies on the finishing of the prepare connections stage) get stuck.

What changed and how does it work?

Selected over the context so it can be canceled.

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
ti-chi-bot[bot] commented 2 weeks ago

This cherry pick PR is for a release branch and has not yet been approved by triage owners. Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign yujuncen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tidb/blob/release-7.5/OWNERS)** - **[br/OWNERS](https://github.com/pingcap/tidb/blob/release-7.5/br/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 1cfc58e0baf87c96ecf151c096d8c7b1ce7f3b7d link true /test mysql-test
idc-jenkins-ci-tidb/check_dev_2 1cfc58e0baf87c96ecf151c096d8c7b1ce7f3b7d link true /test check-dev2
idc-jenkins-ci-tidb/build 1cfc58e0baf87c96ecf151c096d8c7b1ce7f3b7d link true /test build
idc-jenkins-ci-tidb/unit-test 1cfc58e0baf87c96ecf151c096d8c7b1ce7f3b7d link true /test unit-test
idc-jenkins-ci-tidb/check_dev 1cfc58e0baf87c96ecf151c096d8c7b1ce7f3b7d link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
YuJuncen commented 1 week ago

should be picked in #53027