Closed zimulala closed 2 weeks ago
Hi @zimulala. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 55.7545%. Comparing base (
1d698c7
) to head (800b0b0
). Report is 12 commits behind head on master.
/retest
@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Defined2014, tangenta
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-04-30 02:37:33.103366475 +0000 UTC m=+324806.860502042
: :ballot_box_with_check: agreed by Defined2014.2024-04-30 06:26:19.64581038 +0000 UTC m=+338533.402945950
: :ballot_box_with_check: agreed by tangenta.In response to a cherrypick label: new pull request created to branch release-8.1
: #53002.
What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tidb/issues/52972, close https://github.com/pingcap/tidb/issues/51320
Problem Summary: Case1:
Case2:
Now the TiDB behaviors:
@@sql_mode
isSTRICT_TRANS_TABLES
(Case1) the result isInvalid default value for 'b'
.@@sql_mode
is''
(Case2) the result is successful.Now the MySQL(MySQL 5.7.44 and 8.0.18 MySQL) behaviors:
Invalid default value for 'b'
.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.