pingcap / tidb

TiDB is an open-source, cloud-native, distributed, MySQL-Compatible database for elastic scale and real-time analytics. Try AI-powered Chat2Query free at : https://tidbcloud.com/free-trial
https://pingcap.com
Apache License 2.0
36.27k stars 5.72k forks source link

lightning: performance optimization for post-import conflict detection (#52656) #52990

Closed ti-chi-bot closed 2 weeks ago

ti-chi-bot commented 2 weeks ago

This is an automated cherry-pick of #52656

What problem does this PR solve?

Issue Number: close #52306

Problem Summary: Optimization for lightning conflict detection.

What changed and how does it work?

Performance optimization for post-import conflict detection.

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline:

lyzx2001 commented 2 weeks ago

/cc @easonn7

ti-chi-bot[bot] commented 2 weeks ago

@lyzx2001: GitHub didn't allow me to request PR reviews from the following users: easonn7.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/pingcap/tidb/pull/52990#issuecomment-2082571979): >/cc @easonn7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 68.95425% with 95 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (release-8.1@f37e5f3). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-8.1 #52990 +/- ## ================================================ Coverage ? 71.1328% ================================================ Files ? 1463 Lines ? 420589 Branches ? 0 ================================================ Hits ? 299177 Misses ? 100944 Partials ? 20468 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/52990/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/52990/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `71.1328% <68.9542%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/52990/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/52990/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `53.9957% <0.0000%> (?)` | | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/52990/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <0.0000%> (?)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/52990/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `40.9516% <0.0000%> (?)` | |
easonn7 commented 2 weeks ago

/approve

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, easonn7, lyzx2001

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[lightning/OWNERS](https://github.com/pingcap/tidb/blob/release-8.1/lightning/OWNERS)~~ [Benjamin2037,easonn7] - ~~[pkg/lightning/OWNERS](https://github.com/pingcap/tidb/blob/release-8.1/pkg/lightning/OWNERS)~~ [Benjamin2037] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment