Open lcwangchao opened 2 weeks ago
Hi @lcwangchao. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
Attention: Patch coverage is 80.00000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 74.5399%. Comparing base (
4fe70da
) to head (aea6a28
). Report is 38 commits behind head on master.
/retest
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: YangKeao Once this PR has been reviewed and has the lgtm label, please assign xuhuaiyu for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Timeline:
2024-05-17 05:35:39.678529107 +0000 UTC m=+1804293.435664850
: :ballot_box_with_check: agreed by YangKeao.
What problem does this PR solve?
Issue Number: close #53006
Problem Summary:
After we introduced some static implements for
EvalContext
andExprContext
. It's better to replacemock.Context
withStaticExprContext
for the following reasons:expression
What changed and how does it work?
mock.NewContext
is replaced withmockStmtExprCtx
createContext
is replaced withmockStmtTruncateAsWarningExprCtx
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.