pingcap / tidb

TiDB is an open-source, cloud-native, distributed, MySQL-Compatible database for elastic scale and real-time analytics. Try AI-powered Chat2Query free at : https://tidbcloud.com/free-trial
https://pingcap.com
Apache License 2.0
36.27k stars 5.72k forks source link

ttl,partition: Stabilize test TestReorgPartExtensivePart #53017

Open mjonss opened 2 weeks ago

mjonss commented 2 weeks ago

The tests makes direct changes to table.Meta, which is later read by TTL. Fixed by disable TTL and not trigger the TTL loop when disabled.

What problem does this PR solve?

Issue Number: close #51845

Problem Summary:

What changed and how does it work?

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.3057%. Comparing base (600b2ed) to head (0aeedfb). Report is 79 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #53017 +/- ## ================================================= - Coverage 72.0365% 55.3057% -16.7309% ================================================= Files 1499 1614 +115 Lines 431224 600894 +169670 ================================================= + Hits 310639 332329 +21690 - Misses 101303 245704 +144401 - Partials 19282 22861 +3579 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/53017/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/pingcap/tidb/pull/53017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `36.4573% <100.0000%> (?)` | | | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/53017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `71.2182% <100.0000%> (-0.0290%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/53017/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/53017/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `53.9957% <ø> (ø)` | | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/53017/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <ø> (∅)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/53017/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `46.6317% <ø> (+8.2670%)` | :arrow_up: |
ti-chi-bot[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hawkingrei Once this PR has been reviewed and has the lgtm label, please assign zimulala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb/blob/master/OWNERS)~~ [hawkingrei] - **[pkg/table/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/table/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 3 days ago

[LGTM Timeline notifier]

Timeline: