pingcap / tidb

TiDB is an open-source, cloud-native, distributed, MySQL-Compatible database for elastic scale and real-time analytics. Try AI-powered Chat2Query free at : https://www.pingcap.com/tidb-serverless/
https://pingcap.com
Apache License 2.0
36.32k stars 5.72k forks source link

planner: UPDATE's select plan's output col IDs should be stable (#53268) #53274

Closed ti-chi-bot closed 3 days ago

ti-chi-bot commented 2 weeks ago

This is an automated cherry-pick of #53268

What problem does this PR solve?

Issue Number: close #53236

Problem Summary:

The output UniqueIDs in the UPDATE's SELECT plan should remain unchanged after the optimization.

What changed and how does it work?

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
ti-chi-bot[bot] commented 4 days ago

[LGTM Timeline notifier]

Timeline:

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 81.37255% with 19 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-7.5@3e0f698). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-7.5 #53274 +/- ## ================================================ Coverage ? 72.0018% ================================================ Files ? 1411 Lines ? 410630 Branches ? 0 ================================================ Hits ? 295661 Misses ? 95058 Partials ? 19911 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/53274/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/53274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `72.0018% <81.3725%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/53274/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/53274/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `53.9913% <0.0000%> (?)` | | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/53274/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <0.0000%> (?)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/53274/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `53.4719% <0.0000%> (?)` | |
fixdb commented 4 days ago

/retest

ti-chi-bot[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, hawkingrei, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb/blob/release-7.5/OWNERS)~~ [XuHuaiyu,hawkingrei] - ~~[pkg/expression/OWNERS](https://github.com/pingcap/tidb/blob/release-7.5/pkg/expression/OWNERS)~~ [XuHuaiyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jebter commented 3 days ago

/retest