lightning: provide view for users when using conflict detection

lyzx2001 commented 1 month ago

What problem does this PR solve?

Issue Number: close #52393

Problem Summary:

What changed and how does it work?

Provide view for users regardless of the lightning configuration.

Check List

Tests

[x] Unit test
[x] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test
- [ ] I checked and no code files have been changed.

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

For lightning conflict detection "replace" mode, the conflicting data are recorded in the `lightning_task_info.conflict_view` view of the target TiDB cluster.
If the value for column is_precheck_conflict is 0, it stands for conflicting data detected by post-import conflict detection in the physical import mode; If the value for column is_precheck_conflict is 1, it stands for conflicting data detected by preprocess conflict detection in both logical and physical import modes.

tiprow[bot] commented 1 month ago

Hi @lyzx2001. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 1 month ago

/test pull-lightning-integration-test

tiprow[bot] commented 1 month ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/53289#issuecomment-2111672673): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 73.8923%. Comparing base (fa94f49) to head (c1b6312). Report is 65 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #53289 +/- ## ================================================ + Coverage 72.4109% 73.8923% +1.4814% ================================================ Files 1493 1546 +53 Lines 429341 453630 +24289 ================================================ + Hits 310890 335198 +24308 + Misses 99162 97597 -1565 - Partials 19289 20835 +1546 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/53289/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/pingcap/tidb/pull/53289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `50.6486% <57.1428%> (?)` | | | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/53289/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `71.3458% <28.5714%> (+0.0429%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/53289/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/53289/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `53.9957% <ø> (ø)` | | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/53289/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <ø> (∅)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/53289/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `42.0730% <ø> (+0.6361%)` | :arrow_up: |

lyzx2001 commented 1 month ago

/test pull-lightning-integration-test

tiprow[bot] commented 1 month ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/53289#issuecomment-2116570403): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 1 month ago

/test pull-lightning-integration-test

tiprow[bot] commented 1 month ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/53289#issuecomment-2116871573): >/test pull-lightning-integration-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 1 month ago

/cc @lance6716 @D3Hunter

lyzx2001 commented 4 weeks ago

/cc @yudongusa @easonn7

ti-chi-bot[bot] commented 4 weeks ago

@lyzx2001: GitHub didn't allow me to request PR reviews from the following users: yudongusa, easonn7.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/pingcap/tidb/pull/53289#issuecomment-2119662992): >/cc @yudongusa @easonn7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lyzx2001 commented 4 weeks ago

rest lgtm

modified

ti-chi-bot[bot] commented 3 weeks ago

[LGTM Timeline notifier]

Timeline:

2024-05-20 02:41:51.923139512 +0000 UTC m=+2053065.680275085: :ballot_box_with_check: agreed by D3Hunter.
2024-05-21 06:31:03.92279727 +0000 UTC m=+2153217.679932843: :ballot_box_with_check: agreed by lance6716.

lyzx2001 commented 3 weeks ago

/retest

tiprow[bot] commented 3 weeks ago

@lyzx2001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/53289#issuecomment-2121898250): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

easonn7 commented 3 weeks ago

/approve

ti-chi-bot[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, easonn7, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[lightning/OWNERS](https://github.com/pingcap/tidb/blob/master/lightning/OWNERS)~~ [D3Hunter,easonn7,lance6716] - ~~[pkg/lightning/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/lightning/OWNERS)~~ [D3Hunter,lance6716] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tidb