pingcap / tidb

TiDB is an open-source, cloud-native, distributed, MySQL-Compatible database for elastic scale and real-time analytics. Try AI-powered Chat2Query free at : https://www.pingcap.com/tidb-serverless/
https://pingcap.com
Apache License 2.0
36.32k stars 5.72k forks source link

planner, statistics: async load should load all column meta info for lite init #53297

Closed winoros closed 2 weeks ago

winoros commented 2 weeks ago

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/issues/53141

Problem Summary:

What changed and how does it work?

async load should do the same thing for the lite init

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 77.27273% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 73.8291%. Comparing base (687f39c) to head (8ef215b). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #53297 +/- ## ================================================ - Coverage 74.4673% 73.8291% -0.6383% ================================================ Files 1497 1497 Lines 356783 429959 +73176 ================================================ + Hits 265687 317435 +51748 - Misses 71801 92588 +20787 - Partials 19295 19936 +641 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/53297/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/pingcap/tidb/pull/53297/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `26.5423% <46.9697%> (?)` | | | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/53297/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `71.2911% <77.2727%> (-1.9490%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/53297/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/53297/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `53.9957% <ø> (-2.3014%)` | :arrow_down: | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/53297/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <ø> (∅)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/53297/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `50.1237% <ø> (+7.1528%)` | :arrow_up: |
ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/planner/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/planner/OWNERS)~~ [hawkingrei,time-and-fate] - ~~[pkg/statistics/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/statistics/OWNERS)~~ [hawkingrei,time-and-fate] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline:

winoros commented 2 weeks ago

/cherrypick release-8.1

ti-chi-bot commented 2 weeks ago

@winoros: new pull request created to branch release-8.1: #53307.

In response to [this](https://github.com/pingcap/tidb/pull/53297#issuecomment-2113439391): >/cherrypick release-8.1 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
hawkingrei commented 1 week ago

/cherrypick release-7.5

ti-chi-bot commented 1 week ago

@hawkingrei: new pull request created to branch release-7.5: #53456.

In response to [this](https://github.com/pingcap/tidb/pull/53297#issuecomment-2122650730): >/cherrypick release-7.5 Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.