executor: fix negative consumedbyte for hashRowcontainer (#50843)

pingcap / tidb

TiDB is an open-source, cloud-native, distributed, MySQL-Compatible database for elastic scale and real-time analytics. Try AI-powered Chat2Query free at : https://www.pingcap.com/tidb-serverless/

https://pingcap.com

Apache License 2.0

36.4k stars 5.73k forks source link

executor: fix negative consumedbyte for hashRowcontainer (#50843) #53344

Closed ti-chi-bot closed 1 month ago

ti-chi-bot commented 1 month ago

This is an automated cherry-pick of #50843

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb/issues/50841

Problem Summary:

What changed and how does it work?

Check List

Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No need to test
- [ ] I checked and no code files have been changed.

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that goroutine leak when hashJoin triggered spill and sql failed

ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb/blob/release-6.5-20231229-v6.5.6/OWNERS)~~ [XuHuaiyu,guo-shaoge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 1 month ago

[LGTM Timeline notifier]

Timeline:

2024-05-17 03:38:11.852741731 +0000 UTC m=+1797245.609877297: :ballot_box_with_check: agreed by guo-shaoge.
2024-05-17 03:38:29.423688832 +0000 UTC m=+1797263.180824406: :ballot_box_with_check: agreed by XuHuaiyu.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-6.5-20231229-v6.5.6@72f3dd2). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release-6.5-20231229-v6.5.6 #53344 +/- ## ================================================================ Coverage ? 73.6500% ================================================================ Files ? 1088 Lines ? 349670 Branches ? 0 ================================================================ Hits ? 257532 Misses ? 75598 Partials ? 16540 ```