Closed you06 closed 1 week ago
This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved
label.
To merge this cherry pick:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign tangenta for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @you06. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
Attention: Patch coverage is 48.33333%
with 31 lines
in your changes are missing coverage. Please review.
Please upload report for BASE (
release-8.1@d4fe60e
). Learn more about missing BASE report.
Close thie PR because we won't backport it to 8.1, supress the regression by #53429.
cherry pick #53299 to release-8.1 branch
What problem does this PR solve?
Issue Number: close #52887
Problem Summary:
What changed and how does it work?
Goroutines with short lifetime often release its stack soon after several stack grows, this made
newstack
a performance issue. This PR create a global goroutine pool, reuse the stack, which shows a great improvement, high QPS with lower CPU utilization.Check List
Tests
Sysbench read only(with
--point-selects=0
)TPC-C
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.