Slow log query's parse concurrency is not stable - Githubissues

pingcap / tidb

TiDB is an open-source, cloud-native, distributed, MySQL-Compatible database for elastic scale and real-time analytics. Try AI-powered Chat2Query free at : https://www.pingcap.com/tidb-serverless/

https://pingcap.com

Apache License 2.0

36.69k stars 5.78k forks source link

Slow log query's parse concurrency is not stable #54522

Open yibin87 opened 3 weeks ago

yibin87 commented 3 weeks ago

Enhancement

There are two types of concurency for parsing slow query log, decided by whether Desc attribute is true: https://github.com/pingcap/tidb/blob/d8098b970893c850cc318727d9dc336d0a677f35/pkg/executor/slow_query.go#L451-L455

When Desc is true, the concurrency will be DistSQLScanConcurrency
When false, the concurrency will be 1, due to the parsed log's first dimension length is always <= 1: https://github.com/pingcap/tidb/blob/d8098b970893c850cc318727d9dc336d0a677f35/pkg/executor/slow_query.go#L316 https://github.com/pingcap/tidb/blob/d8098b970893c850cc318727d9dc336d0a677f35/pkg/executor/slow_query.go#L348

yibin87 commented 3 weeks ago

/assign @yibin87