Closed ti-chi-bot closed 2 days ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Benjamin2037, hawkingrei
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-11-20 08:02:09.491580771 +0000 UTC m=+18717.111235287
: :ballot_box_with_check: agreed by Benjamin2037.2024-11-20 08:02:20.093808079 +0000 UTC m=+18727.713462595
: :ballot_box_with_check: agreed by hawkingrei.All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
release-8.5@03a5897
). Learn more about missing BASE report.
🚨 Try these New Features:
/retest
This is an automated cherry-pick of #57506
What problem does this PR solve?
Issue Number: close #56987
Problem Summary:
InfoSchemaBaseExtractor
wrongly filter table names for the fast path introduced by https://github.com/pingcap/tidb/pull/55574What changed and how does it work?
Introduce a new variable
extractLowerString
to dertermine whether to do case-insensitive comparisons for specific columns.Test case is not added in integration test because we don't want to write some hardcoded value. (ref #57306)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.