Open tangenta opened 5 days ago
Hi @tangenta. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
Attention: Patch coverage is 25.18519%
with 303 lines
in your changes missing coverage. Please review.
Project coverage is 74.6266%. Comparing base (
fe1b9ed
) to head (abd295c
). Report is 13 commits behind head on master.
🚨 Try these New Features:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: D3Hunter Once this PR has been reviewed and has the lgtm label, please ask for approval from tangenta and additionally assign bb7133, bornchanger, d3hunter, yudongusa for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Timeline:
2024-11-25 08:21:19.905921193 +0000 UTC m=+451867.525575708
: :ballot_box_with_check: agreed by D3Hunter.
What problem does this PR solve?
Issue Number: close #57552, close #57551
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.