pingcap / tidb

TiDB - the open-source, cloud-native, distributed SQL database designed for modern applications.
https://pingcap.com
Apache License 2.0
37.37k stars 5.86k forks source link

ddl: support pre-split index regions before creating index #57553

Open tangenta opened 5 days ago

tangenta commented 5 days ago

What problem does this PR solve?

Issue Number: close #57552, close #57551

Problem Summary:

What changed and how does it work?

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
tiprow[bot] commented 5 days ago

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 25.18519% with 303 lines in your changes missing coverage. Please review.

Project coverage is 74.6266%. Comparing base (fe1b9ed) to head (abd295c). Report is 13 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #57553 +/- ## ================================================ + Coverage 72.8112% 74.6266% +1.8153% ================================================ Files 1676 1724 +48 Lines 463677 474170 +10493 ================================================ + Hits 337609 353857 +16248 + Misses 105228 98094 -7134 - Partials 20840 22219 +1379 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/57553/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/pingcap/tidb/pull/57553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `49.0965% <17.0940%> (?)` | | | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/57553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `72.1565% <25.1851%> (-0.0556%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/57553/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/57553/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `52.7673% <ø> (ø)` | | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/57553/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <ø> (∅)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/57553/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `60.6250% <ø> (+15.1660%)` | :arrow_up: |

🚨 Try these New Features:

ti-chi-bot[bot] commented 18 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: D3Hunter Once this PR has been reviewed and has the lgtm label, please ask for approval from tangenta and additionally assign bb7133, bornchanger, d3hunter, yudongusa for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb/blob/master/OWNERS)~~ [D3Hunter] - ~~[pkg/ddl/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/ddl/OWNERS)~~ [D3Hunter] - ~~[pkg/meta/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/meta/OWNERS)~~ [D3Hunter] - **[pkg/parser/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/parser/OWNERS)** [D3Hunter] > Need more approvers for rest parts. Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 18 hours ago

[LGTM Timeline notifier]

Timeline: