dxf: systable and scheduler change for modify task at runtime

D3Hunter commented 5 days ago

What problem does this PR solve?

Issue Number: ref #57497

Problem Summary:

What changed and how does it work?

Add a new task state modifying and add a new field modify_params which holds parameters about current modification. the system table change part has verified with PM @frank945946 Add some basic interface in storage for modify and add a empty impl in scheduler

Check List

Tests

[x] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)

upgrade from 8.1, success, task and history table matches bootstrap with master, success, task and history table matches

[ ] No need to test
- [ ] I checked and no code files have been changed.

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow[bot] commented 5 days ago

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 64.70588% with 30 lines in your changes missing coverage. Please review.

Project coverage is 74.6500%. Comparing base (14ff938) to head (db59aaa). Report is 7 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #57557 +/- ## ================================================ + Coverage 72.8292% 74.6500% +1.8207% ================================================ Files 1676 1692 +16 Lines 463753 464517 +764 ================================================ + Hits 337748 346762 +9014 + Misses 105139 96324 -8815 - Partials 20866 21431 +565 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/57557/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/pingcap/tidb/pull/57557/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `46.6196% <3.7037%> (?)` | | | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/57557/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `72.3708% <67.0731%> (+0.1464%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/57557/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/57557/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `52.7673% <ø> (ø)` | | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/57557/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <ø> (∅)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/57557/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `61.1456% <ø> (+15.7078%)` | :arrow_up: |

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

D3Hunter commented 5 days ago

/retest

tiprow[bot] commented 5 days ago

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/57557#issuecomment-2488271161): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

D3Hunter commented 4 days ago

/retest

tiprow[bot] commented 4 days ago

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/pingcap/tidb/pull/57557#issuecomment-2490461551): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

ti-chi-bot[bot] commented 22 hours ago

[LGTM Timeline notifier]

Timeline:

2024-11-25 02:58:17.644615751 +0000 UTC m=+432485.264270252: :ballot_box_with_check: agreed by joccau.
2024-11-25 05:01:05.785209065 +0000 UTC m=+439853.404863580: :ballot_box_with_check: agreed by fzzf678.

D3Hunter commented 20 hours ago

/approve

for disttask pkg

ti-chi-bot[bot] commented 20 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, fzzf678, joccau, yudongusa, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[br/OWNERS](https://github.com/pingcap/tidb/blob/master/br/OWNERS)~~ [YuJuncen] - ~~[pkg/disttask/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/disttask/OWNERS)~~ [D3Hunter] - ~~[pkg/session/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/session/OWNERS)~~ [yudongusa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tidb