Closed ti-chi-bot closed 4 days ago
This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved
label.
To merge this cherry pick:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign wjhuang2016 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
It's in v8.5 already, so no need to cherry-pick.
@ti-chi-bot: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
idc-jenkins-ci-tidb/build | ae50d72a9ed021afca889bcdf6a5a9a30a63c8e6 | link | true | /test build |
idc-jenkins-ci-tidb/check_dev_2 | ae50d72a9ed021afca889bcdf6a5a9a30a63c8e6 | link | true | /test check-dev2 |
idc-jenkins-ci-tidb/unit-test | ae50d72a9ed021afca889bcdf6a5a9a30a63c8e6 | link | true | /test unit-test |
pull-unit-test-ddlv1 | ae50d72a9ed021afca889bcdf6a5a9a30a63c8e6 | link | true | /test pull-unit-test-ddlv1 |
idc-jenkins-ci-tidb/check_dev | ae50d72a9ed021afca889bcdf6a5a9a30a63c8e6 | link | true | /test check-dev |
idc-jenkins-ci-tidb/mysql-test | ae50d72a9ed021afca889bcdf6a5a9a30a63c8e6 | link | true | /test mysql-test |
Full PR test history. Your PR dashboard.
This is an automated cherry-pick of #55847
What problem does this PR solve?
Issue Number: close #55846 #53329
Problem Summary:
What changed and how does it work?
In the previous logic,
rename table
will reuse the oldAllocator
.For the first case in the issue,
drop database
will clear all related meta data with old schema. So the next call ofrebase4Signed
will allocate ids from 0.For the second case, after infoschema reload, the
Allocator
created inloadTableInfo
will allocate id starting from 0, which may generate duplicated keys.This affects both v1 and v2.
To solve these problem, old meta will be copied for new table after
rename table
. So new table will never get an already allocated id.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.