pingcap / tidb

TiDB - the open-source, cloud-native, distributed SQL database designed for modern applications.
https://pingcap.com
Apache License 2.0
37.37k stars 5.86k forks source link

statistics: use infoschema api to get table info #57574

Closed hawkingrei closed 4 days ago

hawkingrei commented 4 days ago

What problem does this PR solve?

Issue Number: close #57573

Problem Summary:

What changed and how does it work?

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.9399%. Comparing base (e4e707d) to head (e49e268). Report is 14 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #57574 +/- ## ================================================ + Coverage 72.8372% 73.9399% +1.1026% ================================================ Files 1676 1706 +30 Lines 463627 473966 +10339 ================================================ + Hits 337693 350450 +12757 + Misses 105112 102229 -2883 - Partials 20822 21287 +465 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/57574/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/pingcap/tidb/pull/57574/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `46.7223% <100.0000%> (?)` | | | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/57574/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `72.5770% <100.0000%> (+0.3492%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/57574/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/57574/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `52.7673% <ø> (ø)` | | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/57574/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <ø> (∅)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/57574/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `45.4449% <ø> (-0.0176%)` | :arrow_down: |

🚨 Try these New Features:

hawkingrei commented 4 days ago

/test fast_test_tiprow

tiprow[bot] commented 4 days ago

@ti-chi-bot[bot]: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/pingcap/tidb/pull/57574#issuecomment-2490177982): >@hawkingrei: The specified target(s) for `/test` were not found. >The following commands are available to trigger required jobs: >``` >/test build >``` >``` >/test check-dev >``` >``` >/test check-dev2 >``` >``` >/test mysql-test >``` >``` >/test pull-br-integration-test >``` >``` >/test pull-integration-ddl-test >``` >``` >/test pull-integration-e2e-test >``` >``` >/test pull-lightning-integration-test >``` >``` >/test pull-mysql-client-test >``` >``` >/test pull-unit-test-ddlv1 >``` >``` >/test unit-test >``` > >The following commands are available to trigger optional jobs: >``` >/test pingcap/tidb/canary_ghpr_unit_test >``` >``` >/test pull-common-test >``` >``` >/test pull-e2e-test >``` >``` >/test pull-integration-common-test >``` >``` >/test pull-integration-copr-test >``` >``` >/test pull-integration-jdbc-test >``` >``` >/test pull-integration-mysql-test >``` >``` >/test pull-integration-nodejs-test >``` >``` >/test pull-integration-python-orm-test >``` >``` >/test pull-sqllogic-test >``` >``` >/test pull-tiflash-test >``` > >Use `/test all` to run the following jobs that were automatically triggered: >``` >pingcap/tidb/ghpr_build >``` >``` >pingcap/tidb/ghpr_check >``` >``` >pingcap/tidb/ghpr_check2 >``` >``` >pingcap/tidb/ghpr_mysql_test >``` >``` >pingcap/tidb/ghpr_unit_test >``` >``` >pingcap/tidb/pull_integration_ddl_test >``` >``` >pingcap/tidb/pull_integration_e2e_test >``` >``` >pingcap/tidb/pull_lightning_integration_test >``` >``` >pingcap/tidb/pull_mysql_client_test >``` > > > >
> >In response to [this](https://github.com/pingcap/tidb/pull/57574#issuecomment-2490177898): > >>/test fast_test_tiprow > > >Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei commented 4 days ago

/test fast_test_tiprow

tiprow[bot] commented 4 days ago

@ti-chi-bot[bot]: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/pingcap/tidb/pull/57574#issuecomment-2490188447): >@hawkingrei: The specified target(s) for `/test` were not found. >The following commands are available to trigger required jobs: >``` >/test build >``` >``` >/test check-dev >``` >``` >/test check-dev2 >``` >``` >/test mysql-test >``` >``` >/test pull-br-integration-test >``` >``` >/test pull-integration-ddl-test >``` >``` >/test pull-integration-e2e-test >``` >``` >/test pull-lightning-integration-test >``` >``` >/test pull-mysql-client-test >``` >``` >/test pull-unit-test-ddlv1 >``` >``` >/test unit-test >``` > >The following commands are available to trigger optional jobs: >``` >/test pingcap/tidb/canary_ghpr_unit_test >``` >``` >/test pull-common-test >``` >``` >/test pull-e2e-test >``` >``` >/test pull-integration-common-test >``` >``` >/test pull-integration-copr-test >``` >``` >/test pull-integration-jdbc-test >``` >``` >/test pull-integration-mysql-test >``` >``` >/test pull-integration-nodejs-test >``` >``` >/test pull-integration-python-orm-test >``` >``` >/test pull-sqllogic-test >``` >``` >/test pull-tiflash-test >``` > >Use `/test all` to run the following jobs that were automatically triggered: >``` >pingcap/tidb/ghpr_build >``` >``` >pingcap/tidb/ghpr_check >``` >``` >pingcap/tidb/ghpr_check2 >``` >``` >pingcap/tidb/ghpr_mysql_test >``` >``` >pingcap/tidb/ghpr_unit_test >``` >``` >pingcap/tidb/pull_integration_ddl_test >``` >``` >pingcap/tidb/pull_integration_e2e_test >``` >``` >pingcap/tidb/pull_lightning_integration_test >``` >``` >pingcap/tidb/pull_mysql_client_test >``` > > > >
> >In response to [this](https://github.com/pingcap/tidb/pull/57574#issuecomment-2490188370): > >>/test fast_test_tiprow > > >Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei commented 4 days ago

/retest

hawkingrei commented 4 days ago

/retest

ti-chi-bot[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/statistics/OWNERS](https://github.com/pingcap/tidb/blob/master/pkg/statistics/OWNERS)~~ [winoros] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 4 days ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot commented 4 days ago

In response to a cherrypick label: new pull request created to branch release-8.5: #57614.