pingcap / tidb

TiDB - the open-source, cloud-native, distributed SQL database designed for modern applications.
https://pingcap.com
Apache License 2.0
37.34k stars 5.85k forks source link

ddl: add COMMENTS column to DDL jobs and enhance job reorg meta handling (#57392) #57595

Closed ti-chi-bot closed 22 hours ago

ti-chi-bot commented 1 day ago

This is an automated cherry-pick of #57392

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tidb/issues/57229 #57526

Problem Summary: See #57229

What changed and how does it work?

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

add COMMENTS column to ADMIN SHOW DDL JOBS
codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 85.62500% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@9862e83). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-8.5 #57595 +/- ## ================================================ Coverage ? 56.9561% ================================================ Files ? 1770 Lines ? 626357 Branches ? 0 ================================================ Hits ? 356749 Misses ? 245455 Partials ? 24153 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/57595/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/pingcap/tidb/pull/57595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `36.9042% <63.1250%> (?)` | | | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/57595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `72.5944% <79.3750%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/57595/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/57595/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `52.9478% <0.0000%> (?)` | | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/57595/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <0.0000%> (?)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/57595/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `52.2873% <0.0000%> (?)` | |

🚨 Try these New Features:

ti-chi-bot[bot] commented 1 day ago

[LGTM Timeline notifier]

Timeline:

tangenta commented 1 day ago

/retest

ti-chi-bot[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tidb/blob/release-8.5/OWNERS)~~ [YuJuncen,hawkingrei,tangenta] - ~~[br/OWNERS](https://github.com/pingcap/tidb/blob/release-8.5/br/OWNERS)~~ [YuJuncen] - ~~[pkg/ddl/OWNERS](https://github.com/pingcap/tidb/blob/release-8.5/pkg/ddl/OWNERS)~~ [tangenta] - ~~[pkg/meta/OWNERS](https://github.com/pingcap/tidb/blob/release-8.5/pkg/meta/OWNERS)~~ [tangenta] - ~~[pkg/planner/OWNERS](https://github.com/pingcap/tidb/blob/release-8.5/pkg/planner/OWNERS)~~ [hawkingrei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment