pingcap / tidb

TiDB - the open-source, cloud-native, distributed SQL database designed for modern applications.
https://pingcap.com
Apache License 2.0
37.34k stars 5.85k forks source link

log backup: set a proper maxVersion to resolve lock (#57178) #57598

Closed ti-chi-bot closed 3 hours ago

ti-chi-bot commented 1 day ago

This is an automated cherry-pick of #57178

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tidb/issues/57134

Problem Summary:

  1. See issue.

What changed and how does it work?

To minimize the risk of lock conflicts, set the maxVersion to be the largest existing version value across all slow regions, incremented by 1. This adjustment helps optimize RPO by proactively reducing lock contention.

Check List

Tests

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-8.5@9862e83). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-8.5 #57598 +/- ## ================================================ Coverage ? 56.8557% ================================================ Files ? 1770 Lines ? 626452 Branches ? 0 ================================================ Hits ? 356174 Misses ? 246182 Partials ? 24096 ``` | [Flag](https://app.codecov.io/gh/pingcap/tidb/pull/57598/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/pingcap/tidb/pull/57598/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `36.8274% <0.0000%> (?)` | | | [unit](https://app.codecov.io/gh/pingcap/tidb/pull/57598/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `72.5038% <100.0000%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/pingcap/tidb/pull/57598/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [dumpling](https://app.codecov.io/gh/pingcap/tidb/pull/57598/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `52.9478% <0.0000%> (?)` | | | [parser](https://app.codecov.io/gh/pingcap/tidb/pull/57598/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `∅ <0.0000%> (?)` | | | [br](https://app.codecov.io/gh/pingcap/tidb/pull/57598/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `52.3008% <0.0000%> (?)` | |

🚨 Try these New Features:

BornChanger commented 23 hours ago

/retest

ti-chi-bot[bot] commented 8 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[br/OWNERS](https://github.com/pingcap/tidb/blob/release-8.5/br/OWNERS)~~ [3pointer,BornChanger] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 8 hours ago

[LGTM Timeline notifier]

Timeline:

BornChanger commented 6 hours ago

/retest

BornChanger commented 4 hours ago

/retest